Re: Migrating gcc.c-torture

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi!

On Fri, 22 Aug 2014 14:18:32 +0200, Bernd Schmidt <bernds@codesourcery.com> wrote:
> On 07/29/2014 12:36 AM, Joseph S. Myers wrote:
> > On Thu, 24 Jul 2014, Jakub Jelinek wrote:
> >> Yeah.  I believe gcc.c-torture/compile/ has been converted already,
> >> so it is just about gcc.c-torture/execute/.

> >> So, please just tweak execute.exp, so that it does what it did until now
> >> (perhaps with the exception of *.x files support) in dg framework, and
> >> convert *.exp files into dg-* directives in the testcases.
> >
> > And note that this is bug 20567.  Existing dg-* directive uses in
> > gcc.c-torture/execute/ (which are currently ignored) may or may not be
> > correct, so they should be reviewed as part of such a migration to decide
> > whether they should stay or be removed.  (There aren't that many of them
> > to review.)

Should PR20567 now be updated?

> Here's another attempt.  [...]

> --- a/gcc/testsuite/gcc.c-torture/execute/execute.exp
> +++ b/gcc/testsuite/gcc.c-torture/execute/execute.exp
> @@ -22,28 +22,17 @@
>  # C torture test suite.

> -set-torture-options $C_TORTURE_OPTIONS {{}} $LTO_TORTURE_OPTIONS
> +# Main loop.
> +set saved-dg-do-what-default ${dg-do-what-default}
> +set dg-do-what-default "run"
> +gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] "" "-w"
> +set dg-do-what-default ${saved-dg-do-what-default}

> -foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.c]] {
> -    # If we're only testing specific files and this isn't one of them, skip it.
> -    if ![runtest_file_p $runtests $src] then {
> -	continue
> -    }
> -
> -    c-torture-execute $src
> -}

I noticed that this change causes that the Â-Og -g option combination
(which is part of C_TORTURE_OPTIONS) is no longer being tested with
gcc-dg-runtest.  (The same thing happend for all the tests that were
moved from gcc.c-torture/unsorted/ to gcc.c-torture/compile/.)  Would it
be desirable to restore testing of that option combination, maybe
generally for gcc-dg-runtest, or would that be overkill?


GrÃÃe,
 Thomas

Attachment: pgpfC751btPF9.pgp
Description: PGP signature