This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: fix gfcov regression

From: Nathan Sidwell <nathan at acm dot org>
To: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
Date: Tue, 02 Sep 2014 20:43:48 -0400
Subject: Re: fix gfcov regression
Authentication-results: sourceware.org; auth=none
References: <53F8A620 dot 9080300 at acm dot org>

On 08/23/14 10:33, Nathan Sidwell wrote:

Hi,
this patch fixes a defect Jan found with firefox and its shared objects.  We
were inadvertently calling an externally visible and overridable symbol, rather
than the local shared object's instance.  This led to strangely sparse gcov
results.

I've taken the STRONG_ALIAS #define from glibc.  I'm not 100% sure it's valid
for all supported targets.

Tested in x86_64-linux

I've not committed this patch because of that, and (b) I'm  about to emmigrate,
so likely to be unable to respond to any potential fallout in a timely manner.


I've committed the patch now.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]