This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Yvan Roux <yvan dot roux at linaro dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 27 Aug 2014 13:26:08 +0100
- Subject: Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8
- Authentication-results: sourceware.org; auth=none
- References: <CAD57uCfdEcjrvyYPASp1VPR-LRr=3fxMuMuXgVjZhzDwafT4cA at mail dot gmail dot com> <53FDA3EB dot 2060703 at arm dot com> <CAD57uCdJfGO8Eud60VnQMNmvLJj6n4z0qqWGK6DmBiR3gyQsYw at mail dot gmail dot com> <CAD57uCecQ6eKZSC+ZgJrDbKae_K_rYy_m5ofpv-a8+yQJAAptQ at mail dot gmail dot com> <CAD57uCdD8YC-zH1+k-k4EyVo9gZexv-=+YTjuCqmKJSc-ca0kQ at mail dot gmail dot com>
On 27/08/14 12:35, Yvan Roux wrote:
> with the PR in the ChangeLog:
>
> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>
> PR other/62248
> * config.gcc (arm*-*-*): Check --with-fpu against arm-fpus.def.
>
>
OK, thanks.
R.
> On 27 August 2014 13:10, Yvan Roux <yvan.roux@linaro.org> wrote:
>> Here is the patch that uses the arm-fpus.def list.
>>
>> Thanks
>> Yvan
>>
>> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>>
>> * config.gcc (arm*-*-*): Check --with-fpu against arm-fpus.def.
>>
>> On 27 August 2014 12:35, Yvan Roux <yvan.roux@linaro.org> wrote:
>>> On 27 August 2014 11:24, Richard Earnshaw <rearnsha@arm.com> wrote:
>>>> On 27/08/14 09:04, Yvan Roux wrote:
>>>>> Hi,
>>>>>
>>>>> as reported in PR62248 there is a typo in gcc/config.gcc where
>>>>> --with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in
>>>>> config.gcc). Here is the patch to fix it.
>>>>>
>>>>> Thanks,
>>>>> Yvan
>>>>>
>>>>> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>>>>>
>>>>> * config.gcc: Fix fp-armv8 option for arm*-*-* targets.
>>>>>
>>>>>
>>>>> pr62248.diff
>>>>>
>>>>>
>>>>> diff --git a/gcc/config.gcc b/gcc/config.gcc
>>>>> index 6862c127..3f68e3e 100644
>>>>> --- a/gcc/config.gcc
>>>>> +++ b/gcc/config.gcc
>>>>> @@ -3528,7 +3528,7 @@ case "${target}" in
>>>>> | vfp | vfp3 | vfpv3 \
>>>>> | vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \
>>>>> | vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \
>>>>> - | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \
>>>>> + | fpv4-sp-d16 | neon-vfpv4 | fp-armv8 | neon-fp-armv8 \
>>>>> | crypto-neon-fp-armv8)
>>>>> # OK
>>>>> ;;
>>>>>
>>>>
>>>> Ok; but better still would be to change this to use the official list in
>>>> arm-fpus.def (like we do for CPU names).
>>>
>>> Yes indeed, I'll do it that way.
>