This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

fix gfcov regression

From: Nathan Sidwell <nathan at acm dot org>
To: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
Date: Sat, 23 Aug 2014 15:33:04 +0100
Subject: fix gfcov regression
Authentication-results: sourceware.org; auth=none

Hi,

this patch fixes a defect Jan found with firefox and its shared objects. Wewere inadvertently calling an externally visible and overridable symbol, ratherthan the local shared object's instance. This led to strangely sparse gcov results.

I've taken the STRONG_ALIAS #define from glibc. I'm not 100% sure it's validfor all supported targets.


Tested in x86_64-linux

I've not committed this patch because of that, and (b) I'm about to emmigrate,so likely to be unable to respond to any potential fallout in a timely manner.


Jan, if you think this patch is sufficiently safe, please apply.

nathan

Attachment: all.diff
Description: Text document

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]