This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [GSoC][match-and-simplify] add more constant folding tests
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Prathamesh Kulkarni <bilbotheelffriend at gmail dot com>
- Cc: David Malcolm <dmalcolm at redhat dot com>, Diego Novillo <dnovillo at google dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Maxim Kuvyrkov <maxim dot kuvyrkov at linaro dot org>
- Date: Tue, 19 Aug 2014 10:16:16 +0200
- Subject: Re: [GSoC][match-and-simplify] add more constant folding tests
- Authentication-results: sourceware.org; auth=none
- References: <CAJXstsDkM_0zvezGex8WDuoWSO4Vy_caRzDTWahrPsWD7vG=oA at mail dot gmail dot com> <1408383410 dot 2473 dot 28 dot camel at surprise> <CAJXstsBAA-SDnLpUQYr=443wGMN6bJ9r4oE3oOro8TgpixFxDg at mail dot gmail dot com>
On Mon, Aug 18, 2014 at 8:00 PM, Prathamesh Kulkarni
<bilbotheelffriend@gmail.com> wrote:
> On Mon, Aug 18, 2014 at 11:06 PM, David Malcolm <dmalcolm@redhat.com> wrote:
>> On Mon, 2014-08-18 at 01:11 +0530, Prathamesh Kulkarni wrote:
>>> We now have at-least one test-case for each of constant folding
>>> patterns
>>> in match-constant-folding.pd
>>>
>>> [gcc/testsuite/gcc.dg/tree-ssa]
>>> * match-constant-folding.c: Add test-cases.
>>>
>>> [...snip...]
>>
>> A minor nit for one of the comments, for modulo division:
>>
>>> Index: match-constant-folding.c
>>> ===================================================================
>>> --- match-constant-folding.c (revision 214020)
>>> +++ match-constant-folding.c (working copy)
>> [...]
>>
>>> +/* x % x -> 1 */
>> ^
>> 0, rather than 1, surely?
> Thanks, fixed in this patch.
>
> * testsuite/match-constant-folding.c: Fix typo.
Applied.
Richard.
> Regards,
> Prathamesh
>>
>>
>>