This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal
- From: Mikael Morin <mikael dot morin at sfr dot fr>
- To: Andre Vehreschild <vehre at gmx dot de>, fortran at gcc dot gnu dot org
- Cc: fxcoudert at gmail dot com, gcc-patches at gcc dot gnu dot org, Dominique d'Humières <dominiq at lps dot ens dot fr>
- Date: Sun, 17 Aug 2014 13:42:16 +0200
- Subject: Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal
- Authentication-results: sourceware.org; auth=none
- Authentication-results: sfrmc.priv.atos.fr; dkim=none (no signature); dkim-adsp=none (no policy) header dot from=mikael dot morin at sfr dot fr
- References: <20140721072605 dot 0D680105 at mailhost dot lps dot ens dot fr> <20140721150350 dot 10b35dd3 at vepi2 dot private> <911AF20A-F5E2-474F-858A-BF5CE56235D5 at lps dot ens dot fr> <53D3FF8A dot 106 at sfr dot fr> <20140806212302 dot 4bf07e11 at vepi2 dot private>
Hello,
Le 06/08/2014 21:23, Andre Vehreschild a écrit :
> Hi,
>
[...]
>
> *** gcc/fortran/Changelog ***
> 2014-08-06 Andre Vehreschild <vehre@gmx.de>
>
> PR fortran/60414
> * interface.c (compare_parameter): Fixing ICE when argument
> of a generic is a reference into an array.
> *** gcc/fortran/Changelog ***
The ChangeLog format is good, but the text is not very
helpful/descriptive for someone hunting a bug in compare_parameter in
the future.
You can say (for example):
Remove class argument rank check short circuit.
>
> *** gcc/testsuite/Changelog ***
> 2014-08-06 Andre Vehreschild <vehre@gmx.de>
>
> * gfortran.dg/unlimited_polymorphism_18.f90: Check according to
> PR fortran/60414
> *** gcc/testsuite/Changelog ***
You should add PR fortran/60414 before like in the gcc/fortran Changelog,
and then the text just need to say new/new file/new test (see what the
other contributors use in the rest of the file).
>
> Bootstrapped and regtested on x86_64-unkown-linux-gnu.
>
The patch looks good to me.
With the ChangeLog fixes above, OK if/when the copyright assignment is
settled.
Thanks
Mikael