This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ PATCH] PR c++/62101

From: Ville Voutilainen <ville dot voutilainen at gmail dot com>
To: Jason Merrill <jason at redhat dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Thu, 14 Aug 2014 03:48:53 +0300
Subject: Re: [C++ PATCH] PR c++/62101
Authentication-results: sourceware.org; auth=none
References: <CAFk2RUbmVEjYGcTbLk5fLr1uWzQzq=5dU8HXBv4o0XspVmq=6Q at mail dot gmail dot com> <53EC05C0 dot 8030600 at redhat dot com>

On 14 August 2014 03:41, Jason Merrill <jason@redhat.com> wrote:
> On 08/13/2014 07:06 PM, Ville Voutilainen wrote:
>
> Looks good, but
>
>> +  int friendp = 0;
>
>
> Let's declare friendp when it's initialized.
>
> And I still need a ChangeLog entry.

Ok, modified patch attached. The changelog entry was attached to the previous
mail as an evil binary attachment (gmail...), here, for convenience:

/cp
2014-08-14  Ville Voutilainen  <ville.voutilainen@gmail.com>

    PR c++/62101
    * decl.c (grokdeclarator): Move the check for friend initializers..
    * decl2.c (grokfield) ..here. Remove bogus comment about pure
specifiers, and postpone the previous early return for friends until
after the initializer check.

/testsuite
2014-08-14  Ville Voutilainen  <ville.voutilainen@gmail.com>

    PR c++/62101
    * g++.dg/cpp0x/pr62101.C: New

Attachment: pr62101.diff
Description: Text document

Follow-Ups:
- Re: [C++ PATCH] PR c++/62101
  - From: Jason Merrill

References:
- [C++ PATCH] PR c++/62101
  - From: Ville Voutilainen
- Re: [C++ PATCH] PR c++/62101
  - From: Jason Merrill

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]