This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH, ARM] Fix incorrect alignment of small values in minipool
- From: "Thomas Preud'homme" <thomas dot preudhomme at arm dot com>
- To: "Richard Earnshaw" <Richard dot Earnshaw at arm dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 13 Aug 2014 15:49:18 +0800
- Subject: RE: [PATCH, ARM] Fix incorrect alignment of small values in minipool
- Authentication-results: sourceware.org; auth=none
- References: <000501cfb538$bedfae80$3c9f0b80$ at arm dot com> <53E8849E dot 4010200 at arm dot com>
> From: Richard Earnshaw
> Sent: Monday, August 11, 2014 4:54 PM
>
> I think this is the wrong place for this sort of fix up. HFmode values
> are fixed up in the consttable_4 pattern and it looks wrong to be that
> HImode values are then fixed up in a different place. We should be
> consistent and do all the fix ups in one location.
Sorry for the delay in answering.
The problem is that in the pattern for constable_4 we don't have the information
about the access mode for this entry. In the testcase along this patch the rtx
manipulated in the pattern is VOIDmode while the access mode is HImode. In
dump_minipool on the other hand the information can be found in mp->mode.
Best regards,
Thomas