Re: [PATCH 212/236] Use rtx_expr_list for expr_status.x_forced_labels

[Jeff Law <law at redhat dot com>]

On 08/07/14 05:32, Bernd Schmidt wrote:
> On 08/06/2014 07:23 PM, David Malcolm wrote:
> > diff --git a/gcc/function.h b/gcc/function.h
> > index 28a20f3..ba7597c 100644
> > --- a/gcc/function.h
> > +++ b/gcc/function.h
> > @@ -135,7 +135,7 @@ struct GTY(()) expr_status {
> >     rtx x_apply_args_value;
> >
> >     /* List of labels that must never be deleted.  */
> > -  rtx x_forced_labels;
> > +  rtx_expr_list *x_forced_labels;
> >   };
>
> As I said at the Cauldron, this sort of thing seems like the wrong thing
> to do - when eliminating our own ancient list implementations we should
> just go to normal C++ such as list<rtx>, or maybe even just a vec in
> this case and some others. This applies to both expr_list and insn_list
> - in the end we really shouldn't have either rtx_expr_list or
> rtx_insn_list.
I agree.

But at this point I'd rather see David's work go forward independently, 
then we can go back and do replacement of our home grown list with a 
standard container.  I suspect there's many of these kind of projects 
that could be undertaken throughout GCC's sources.

Jeff