This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] PR55189 enable -Wreturn-type by default
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Sylvestre Ledru <sylvestre at debian dot org>
- Cc: <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
- Date: Tue, 12 Aug 2014 17:48:51 +0000
- Subject: Re: [Patch] PR55189 enable -Wreturn-type by default
- Authentication-results: sourceware.org; auth=none
- References: <538F7856 dot 1090104 at debian dot org> <Pine dot LNX dot 4 dot 64 dot 1406042321130 dot 2874 at digraph dot polyomino dot org dot uk> <53903961 dot 9030501 at debian dot org> <Pine dot LNX dot 4 dot 64 dot 1406051749260 dot 2819 at digraph dot polyomino dot org dot uk> <53A07226 dot 4040803 at debian dot org> <Pine dot LNX dot 4 dot 64 dot 1406171712280 dot 23412 at digraph dot polyomino dot org dot uk> <53A07CCC dot 2030004 at debian dot org> <Pine dot LNX dot 4 dot 64 dot 1406171739550 dot 23412 at digraph dot polyomino dot org dot uk> <53BAD646 dot 7020102 at debian dot org> <Pine dot LNX dot 4 dot 64 dot 1407302205070 dot 3490 at digraph dot polyomino dot org dot uk> <53E8744B dot 5030509 at debian dot org>
On Mon, 11 Aug 2014, Sylvestre Ledru wrote:
> > The test Wmissing-return2.c only has one of the two warnings. But as per
> > "-Wreturn-type => Run both", and for backwards compatibility with the
> > existing definition of -Wreturn-type, both warnings should appear for this
> > test.
> Make sense. Thanks for the feedback and the help.
> Here it is:
> https://github.com/sylvestre/gcc/commit/089ffc9fb85034111b892ee10190dc12b5dbe551
Yes, those tests seem as I expect.
> By the way, do you prefer a single commit for all tests or one per
> directory (gfortran, C++, gcc, OpenMP) ?
Each commit needs to avoid causing regressions. Thus, if a change to
compiler behavior would cause an existing test to fail, the change to the
test needs to be in the same commit as the change of behavior - or in a
previous commit if the changed test works both with and without the
compiler change.
--
Joseph S. Myers
joseph@codesourcery.com