Re: PR tree-optimization/52904 testcase

[Richard Biener <richard dot guenther at gmail dot com>]

On Tue, Aug 12, 2014 at 4:51 AM, Kugan
<kugan.vivekanandarajah@linaro.org> wrote:
>
> On 11/08/14 18:03, Richard Biener wrote:
>> On Sat, Aug 9, 2014 at 2:33 PM, Kugan <kugan.vivekanandarajah@linaro.org> wrote:
>>> Hi,
>>>
>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52904
>>>
>>> Tescase was generating warning: assuming signed overflow does not occur
>>> when simplifying conditional to constant [-Wstrict-overflow] due to VRP
>>> missing the value range.
>>>
>>> This seems to have been fixed and the PR is now closed. However, as
>>> requested there in the PR, I am sending this patch to add the test-case
>>> to test-suite.
>>>
>>>
>>> Is this OK ?
>>
>> Did you verify the testcase fails before the revision that fixed it?
>> Esp. the placement of the dg-bogus looks bogus to me.
>
> I tried it on Linaro 4.9 (It should be the same in fsf gcc 4.9 branch)
> and the test cases is failing there. Passes on trunk.

Well, it probably fails because of excess errors, not because of
the dg-bogus failing.  The dg-bogus has to be on the line that
the warning triggers on.

> In any case, I have moved it to the top and reverified. I have also
> trimmed the warning pattern to check as there was some changes there
> from 4.9 to trunk.
>
>>
>> Also don't use -S in dg-options, use lower-case filenames and
>> avoid spurious vertical white-space.  The VRP dump scan is
>> also very unspecific - I suggest to drop it entirely.
>>
>
> Done.
>
>
> Is this OK?

Err.

@@ -0,0 +1,24 @@
+

Excessive vertical space

+/* { dg-do compile } */
+/* { dg-options "-Wstrict-overflow -O2" } */
+/* { dg-bogus "assuming signed overflow does not occur when simplifying" */
+

Missing closing }

Thanks,
Richard.

>
> Thanks,
> Kugan
>
> gcc/testsuite
> 2014-08-12  Kugan Vivekanandarajah  <kuganv@linaro.org>
>
>         PR tree-optimization/52904
>         * gcc.dg/pr52904.c: New test.
>
>
>
>> Thanks,
>> Richard.
>>
>>> Thanks,
>>> Kugan
>>>
>>> gcc/testsuite
>>>
>>>
>>> 2014-08-09  Kugan Vivekanandarajah  <kuganv@linaro.org>
>>>
>>>         PR tree-optimization/52904
>>>         * gcc.dg/PR52904.c: New test.