This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Fwd: [testsuite patch] fix ARM tests with options that conflict with thumb1
- From: Mike Stump <mikestump at comcast dot net>
- To: Janis Johnson <janisjo at codesourcery dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 11 Aug 2014 16:53:25 -0700
- Subject: Fwd: [testsuite patch] fix ARM tests with options that conflict with thumb1
- Authentication-results: sourceware.org; auth=none
- References: <D4FE3EC0-F4DD-41AE-9A9E-EFB8C8983D39 at mrs dot kithrup dot com>
[ dup, sorry ]
On Aug 11, 2014, at 2:58 PM, Janis Johnson <janis_johnson@mentor.com> wrote:
> Two tests in gcc.target/arm add options that conflict with thumb1
> multilib flags; skip them. Tested with arm-none-linux-gnu for mainline
> and 4.9 for a variety of multilib flags.
>
> OK for mainline and 4.9 branch?
So, my take is you can self-review things like this if you would like. Doesn’t look controversial and likely you understand the issues better than most.
Ok.
Nit, if you discover a way to figure out incompatible options, it would be nicer to use it. The usual gcc rules are, last option wins, which generally precludes noticing conflicting options. I only mention this here, in case people want to contemplate conflicting options.