This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/3] gcc/ada/socket.c: Add conditionals for RTEMS


On 8/11/2014 1:15 PM, Mike Stump wrote:
> On Aug 11, 2014, at 8:08 AM, Joel Sherrill <joel.sherrill@OARcorp.com> wrote:
>> +#if defined(__rtems__)
>> +#include <unistd.h>
>> +/* Required, for read(), write(), and close() */
>> +#endif
> Strikes me as exceptionally odd.  Should be done unconditionally, and any system that doesn’t like that should be the odd ball.

I assume on other targets, these get prototyped by some implicit include.
I found it odd that this wasn't included already also.

Any Ada maintainers want to comment?

-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]