This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR tree-optimization/52904 testcase


On Sat, Aug 9, 2014 at 2:33 PM, Kugan <kugan.vivekanandarajah@linaro.org> wrote:
> Hi,
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52904
>
> Tescase was generating warning: assuming signed overflow does not occur
> when simplifying conditional to constant [-Wstrict-overflow] due to VRP
> missing the value range.
>
> This seems to have been fixed and the PR is now closed. However, as
> requested there in the PR, I am sending this patch to add the test-case
> to test-suite.
>
>
> Is this OK ?

Did you verify the testcase fails before the revision that fixed it?
Esp. the placement of the dg-bogus looks bogus to me.

Also don't use -S in dg-options, use lower-case filenames and
avoid spurious vertical white-space.  The VRP dump scan is
also very unspecific - I suggest to drop it entirely.

Thanks,
Richard.

> Thanks,
> Kugan
>
> gcc/testsuite
>
>
> 2014-08-09  Kugan Vivekanandarajah  <kuganv@linaro.org>
>
>         PR tree-optimization/52904
>         * gcc.dg/PR52904.c: New test.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]