This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: Kugan <kugan dot vivekanandarajah at linaro dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Jay Foad <jay dot foad at gmail dot com>, Uros Bizjak <ubizjak at gmail dot com>
- Date: Tue, 22 Jul 2014 17:31:53 +0100
- Subject: Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4b_Qo3cGw_YJ0aqz7mVK6jZt2-h3uKQCLrgF_OqpAJhiw at mail dot gmail dot com> <53C1B956 dot 1050407 at linaro dot org>
- Reply-to: ramrad01 at arm dot com
On Sat, Jul 12, 2014 at 11:40 PM, Kugan
<kugan.vivekanandarajah@linaro.org> wrote:
>>
>> - if (!TARGET_VFP)
>> - return;
>> + if (!TARGET_VFP || TARGET_THUMB1)
>> + return default_atomic_assign_expand_fenv (hold, clear, update);
>>
>> You don't need to call default function here. It is empty, the
>> documentation says:
>>
>> "The default implementation leaves all three expressions as @code{NULL_TREE}."
>>
>> Also, the function is declared as void, so returning something looks
>> strange to me.
>
> Thanks for the comment. Here is a patch to change this. There was also a
> comment from Jay with respect to a cut and paste error that might
> confuse the readers. I am fixing that as well.
>
> regression tested on qemu for arm-none-linux-gnueabi with no new
> regressions.
>
> Please let me know if this is OK?
Sigh, sorry for missing this earlier. This is OK if no regressions
Ramana
>
> Thanks,
> Kugan
>
> gcc/
> 2014-057-12 Kugan Vivekanandarajah <kuganv@linaro.org>
>
> * config/arm/arm.c (bdesc_2arg): Fix typo.
> (arm_atomic_assign_expand_fenv): Remove The default implementation.