This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix INSN_TICK heuristic for SCHED_PRESSURE
- From: Maxim Kuvyrkov <maxim dot kuvyrkov at linaro dot org>
- To: Steven Bosscher <stevenb dot gcc at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Vladimir Makarov <vmakarov at redhat dot com>, Jeff Law <law at redhat dot com>
- Date: Mon, 14 Jul 2014 20:09:30 +1200
- Subject: Re: [PATCH] Fix INSN_TICK heuristic for SCHED_PRESSURE
- Authentication-results: sourceware.org; auth=none
- References: <17A7E1B3-3DBF-48F7-92B0-6FE94910469F at linaro dot org> <CABu31nMTXpOgP35MJbqbNFDvkSe+qhpGUujV4vba_JTe7o_C2Q at mail dot gmail dot com>
On Jul 14, 2014, at 8:05 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Mon, Jul 14, 2014 at 6:12 AM, Maxim Kuvyrkov wrote:
>> Hi,
>>
>> This patch fixes 2 of the [several] problems in rank_for_schedule heuristics for SCHED_PRESSURE_MODEL. SCHED_PRESSURE_MODEL is used for first scheduling pass in ARM backend by default.
>>
>> The first one is when INSN_TICK of both instructions are equal, and rank_for_schedule returns a "tie" result, even though there are more heuristics down the path to break the tie.
>>
>> The second one is to account for the fact that model_index() of two instructions is meaningful only when both instructions are in the current basic block.
>>
>> Bootstrapped and tested on {x86_64,arm,aarch64}-linux.
>>
>> OK to apply?
>
> s/INSN_BB/BLOCK_FOR_INSN/
That would be a mistake, see definition of INSN_BB in sched-int.h. Scheduler uses its own basic block numbering.
>
> OK with that change.
I assume OK without the change?
Thank you,
--
Maxim Kuvyrkov
www.linaro.org