This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [fortran, patch] IEEE intrinsic modules (ping)

From: FX <fxcoudert at gmail dot com>
To: Uros Bizjak <ubizjak at gmail dot com>
Cc: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Fortran List <fortran at gcc dot gnu dot org>
Date: Thu, 10 Jul 2014 10:45:47 +0200
Subject: Re: [fortran, patch] IEEE intrinsic modules (ping)
Authentication-results: sourceware.org; auth=none
References: <CAFULd4at2o=G7RktfsHf1rpU=V_jkORsMsrsewm0D279aUhxww at mail dot gmail dot com>

> Since all modes are supported, you can unconditionally return 1 in the
> code above, as is the case with fpu-387.h.

Indeed. I’ve committed the attached patch, which performs this trivial cleanup, adds some comments about unreachable cases (I don’t think we want to error out at runtime, but a comment in the code is the least we can do).

It also cleans up the value we return for get_fpu_rounding_mode() when we don’t recognize the rounding mode: it used to be GFC_FPE_INVALID, which is wrong (it’s an “invalid” exception flag, not a marker for an invalid rounding mode). Now, it will return 0, i.e. a nonexisting rounding mode flag, which is more appropriate (though it should never happen in practice).

Committed as rev. 212423 after testing on x86_64-apple-darwin13.

Thanks,
FX

Attachment: z
Description: Binary data

References:
- Re: [fortran, patch] IEEE intrinsic modules (ping)
  - From: Uros Bizjak

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]