This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix aliases on AIX
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 9 Jul 2014 09:35:05 -0400
- Subject: Re: Fix aliases on AIX
- Authentication-results: sourceware.org; auth=none
- References: <20140707200928 dot GC12716 at kam dot mff dot cuni dot cz> <CAGWvnymBxXbowZTM3QYYy4AmD=0f3489M+LzMmHhDx-es=CTwg at mail dot gmail dot com> <20140709045006 dot GC5171 at kam dot mff dot cuni dot cz>
On Wed, Jul 9, 2014 at 12:50 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>> With the patch, GCC on AIX now responds that "ifunc" is supported.
>> The C and C++ attr-ifunc testcases now run and fail.
>
> This is unexpected. I am testing version of the patch with
>
> if (lookup_attribute ("ifunc", DECL_ATTRIBUTES (n->decl)))
> return false;
>
> added to beggining of rs6000_declare_alias. The problem here is that ifunc is
> dealt with as an alias and becuase we output aliases ourselves, we skip the
> sanity checking done in do_assemble_alias. I think that checking is way too
> late, will look into moving it earlier.
>
> I also checked that we won't skip other useful sanity checking there. (other one is
> weakref that we already know to not output in the new way)
>
> Honza
>>
>> g++.dg/ipa/devirt-10 and devirt-15 now fail.
>>
>> Otherwise, the results look very good.
Hi, Honza
Other than those issues, the results generally look good. If you can
correct the patch so that it does not avoid relevant sanity checks, it
should be ready to merge.
Thanks, David