This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, PR 61720] Clear regex BFS match queue after every iteration
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: Paolo Carlini <paolo dot carlini at oracle dot com>, Tim Shen <timshen at google dot com>, libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 9 Jul 2014 10:26:34 +0200
- Subject: Re: [Patch, PR 61720] Clear regex BFS match queue after every iteration
- Authentication-results: sourceware.org; auth=none
- References: <CAG4ZjN=GJoUVDWQVAdC-Pq9JwwHLY8=jX72FBt7fD-Pkb-NCDA at mail dot gmail dot com> <53B9586E dot 2020505 at oracle dot com> <CAG4ZjN=K3JFHBs64s95ZBLph=rnb_-7zCqguat81r128Q91S0Q at mail dot gmail dot com> <53BA5941 dot 9000708 at oracle dot com> <CAG4ZjN=RtUJqbPcOxjgNOvgGWuOJGQ85iXXew+4esV1sFM7HhQ at mail dot gmail dot com> <53BCF3E3 dot 5080208 at oracle dot com> <20140709080840 dot GQ4871 at redhat dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Jul 09, 2014 at 09:08:40AM +0100, Jonathan Wakely wrote:
> >Thus the plan would be *all* the regex testcases in a single file!?! If I
> >understand correctly, that certainly doesn't make sense. In any
>
> Jakub pointed out that there are lots of useful tests for regexes in
> the glibc testsuite. I think it might make sense to have a file of
> tests cases that contains separate fields such as the input string,
> the regex, the flags, and the expected result. Then a test case could
> loop over the contents of that file and run every test.
Most of those glibc tests are actually text file driven, where you have
a small testcase driver which opens the text file, parses it and invokes
regex on the pattern in one column, text to search in another one, with some
flags etc. in yet other columns. 4 different file formats I think, each
with hundreds of individual tests. The reason for different file formats
is where those come from, there are e.g. boost regex tests, rxspencer regex
tests, pcre tests and then supposedly glibc's own old format.
Jakub