This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] PR55189 enable -Wreturn-type by default


Hello,

On 17/06/2014 19:41, Joseph S. Myers wrote:
> On Tue, 17 Jun 2014, Sylvestre Ledru wrote:
> 
>> OK. I will do that.
>> We should test the following:
>> * default => run just -Wreturn-type
>> * -Wreturn-type => Run both
>> * -Wreturn-type + -Wmissing-return => Run both
>> * -Wno-return-type + -Wmissing-return => Run just the second one
>> * -Wno-return-type + -Wno-missing-return => Run none
>> Do you see any other?
> 
> That looks like the right things to test, if there are no changes for 
> anything other than those options.
Here it is:
https://github.com/sylvestre/gcc/commit/db8aaac91aa09fd1ec1cc8974586aec45a221e71

Is that what you expected?

>> Besides that, are you OK with my changes? (with the tests updated)
> 
> The tests are key to reviewing whether the code changes actually do the 
> right thing.
Right.

Thanks again for your help and comments, it is really appreciated,
Sylvestre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]