This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, PR 61720] Clear regex BFS match queue after every iteration


Hi,

On 07/06/2014 10:56 AM, Tim Shen wrote:
This bug shouldn't be introduced, if I wrote clearer code last summer.
Sorry :(. The _Executor is a little bit messy. The _M_match_queue is
not cleared because it's treated `globally` between iterations (in
_M_main_dispatch(..., __bfs)).

Add a new file general_testcases.cc; we can gradually move test cases
to this single file to reduce duplicated compilation in testing?
Patch itself looks obvious to me, but I don't understand the general_testcases.cc idea, do we have something similar elsewhere in library or compiler?!? I would say, let's just add a normal testcase and close the bug (mainline and branch I suppose)

Thanks,
Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]