This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Make declaration of wide_int_storage match its definition
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Gerald Pfeifer <gerald at pfeifer dot com>
- Cc: Andrew Pinski <pinskia at gmail dot com>, gcc-patches at gcc dot gnu dot org, Kenneth Zadeck <zadeck at naturalbridge dot com>, Mike Stump <mikestump at comcast dot net>, Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Sat, 5 Jul 2014 21:29:31 +0200
- Subject: Re: Make declaration of wide_int_storage match its definition
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1407052036320 dot 30120 at tuna dot site> <1825A72A-86F8-4998-8D25-B96A84305C70 at gmail dot com> <alpine dot LSU dot 2 dot 11 dot 1407052113110 dot 30120 at tuna dot site>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sat, Jul 05, 2014 at 09:25:50PM +0200, Gerald Pfeifer wrote:
> On Sat, 5 Jul 2014, pinskia@gmail.com wrote:
> > This patch is fine but c++ allows class and struct be used
> > interchangeable. If there is a compilers which does not it is broken
> > and should be report to them. Yes that means clang is broken.
>
> Clang does allow for it (it actually is the stage 1 compiler on
> FreeBSD 10, the platform I used for my tests); it just warns about
> it. About 400 times.
That doesn't change anything that the warning is very much broken.
In C++ struct is simply a class with default public:, class with a default
private:, when you are just forward declaring it, whether it defaults to
public: or private: doesn't matter at all, therefore the warning just
enforces some weirdo clang coding style.
Jakub