This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Devirtualization dump functions fix
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Martin LiÅka <mliska at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 26 Jun 2014 16:29:10 +0200
- Subject: Re: [PATCH] Devirtualization dump functions fix
- Authentication-results: sourceware.org; auth=none
- References: <53AC19A7 dot 9020907 at suse dot cz> <CAFiYyc2Ocf=gUL-VDcvhba4T_fbmh7nqmcAm-PjvcL-90+np6w at mail dot gmail dot com> <53AC2386 dot 3030309 at suse dot cz> <CAFiYyc0MQAifjA_a=Sqy_gm7W76nGR_Jw2u-yNWEpizr90q=bw at mail dot gmail dot com> <20140626141851 dot GS31640 at tucnak dot redhat dot com> <53AC2DE5 dot 3020607 at suse dot cz>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Jun 26, 2014 at 04:27:49PM +0200, Martin LiÅka wrote:
> >>Well yes - it is of course similar broken in spirit but at least a lot
> >>simpler ;) I'd put a comment there why we do check g for NULL.
> >But it increases overhead, there are hundreds of gimple_location calls
> >and most of them will never pass NULL. Can't you simply
> >do what you do in the inline here in the couple of spots where
> >the stmt might be NULL?
> Sure, do you have any suggestion how should be called such function?
> Suggestion: gimple_location_or_unknown ?
gimple_location_safe or gimple_safe_location?
Jakub