This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix parts of PR61607
- From: Richard Biener <rguenther at suse dot de>
- To: Jeff Law <law at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 26 Jun 2014 09:54:32 +0200 (CEST)
- Subject: Re: [PATCH] Fix parts of PR61607
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1406251602360 dot 29270 at zhemvz dot fhfr dot qr> <53AB14C0 dot 1010606 at redhat dot com>
On Wed, 25 Jun 2014, Jeff Law wrote:
> On 06/25/14 08:05, Richard Biener wrote:
> >
> > This removes restrictions in DOM cprop_operand that inhibit
> > some optimizations. The volatile pointer thing is really realy
> > old and no longer necessary while the loop-depth consideration
> > is only valid for loop-closed PHI nodes (but we're not in
> > loop-closed SSA in DOM) - the coalescing is handled in out-of-SSA
> > phase by inserting copies appropriately.
> >
> > Bootstrapped on x86_64-unknown-linux-gnu, ok?
> >
> > Thanks,
> > Richard.
> >
> > 2014-06-25 Richard Biener <rguenther@suse.de>
> >
> > PR tree-optimization/61607
> > * tree-ssa-dom.c (cprop_operand): Remove restriction on
> > propagating volatile pointers and on loop depth.
> The first hunk is OK.
>
> I thought we had tests for the do not copy propagate out of a loop nest in the
> suite. Did you check that tests in BZ 19038 still generate good code after
> this change? If we still generate good code for those tests, then this hunk
> is fine too.
I have applied the first hunk and will investigate further. Testing
didn't show any issue and I know how to retain the check but not
cause the missed optimization shown in PR61607.
Richard.