This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, 3/10] skip swapping operands used in ccmp
- From: Zhenqiang Chen <zhenqiang dot chen at linaro dot org>
- To: Jeff Law <law at redhat dot com>
- Cc: Richard Earnshaw <rearnsha at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 26 Jun 2014 15:12:20 +0800
- Subject: Re: [PATCH, 3/10] skip swapping operands used in ccmp
- Authentication-results: sourceware.org; auth=none
- References: <CACgzC7DLadpmeQ9eS6Zn3jSJKF_LytV0hkjt3D8i8APMmhErzA at mail dot gmail dot com> <53AAE055 dot 6070608 at arm dot com> <53AB3917 dot 1020608 at redhat dot com>
On 26 June 2014 05:03, Jeff Law <law@redhat.com> wrote:
> On 06/25/14 08:44, Richard Earnshaw wrote:
>>
>> On 23/06/14 07:58, Zhenqiang Chen wrote:
>>>
>>> Hi,
>>>
>>> Swapping operands in a ccmp will lead to illegal instructions. So the
>>> patch disables it in simplify_while_replacing.
>>>
>>> The patch is separated from
>>> https://gcc.gnu.org/ml/gcc-patches/2014-02/msg01407.html.
>>>
>>> To make it clean. The patch adds two files: ccmp.{c,h} to hold all new
>>> ccmp related functions.
>>>
>>> OK for trunk?
>>>
>>> Thanks!
>>> -Zhenqiang
>>>
>>> ChangeLog:
>>> 2014-06-23 Zhenqiang Chen <zhenqiang.chen@linaro.org>
>>>
>>> * Makefile.in: Add ccmp.o
>>> * ccmp.c: New file.
>>
>>
>> Do we really need a new file for one 10-line function? Seems like
>> overkill. I think it would be better to just drop this function into
>> recog.c.
>
> Right. And if we did want a new file, clearly the #includes need to be
> trimmed :-)
Yes. It is not necessary for this patch itself. The file is in need
for "[PATCH, 4/10] expand ccmp". Overall it will have more than 300
lines of codes. And #includes are trimmed.
Previously all codes were in expr.c. It always conflicted when
rebasing. So I move them in separate files.
Thanks!
-Zhenqiang