This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch passes.def]: Fix regression on ARM PR/61608

From: Jeff Law <law at redhat dot com>
To: Kai Tietz <ktietz70 at googlemail dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Henderson <rth at redhat dot com>
Date: Wed, 25 Jun 2014 09:28:12 -0600
Subject: Re: [patch passes.def]: Fix regression on ARM PR/61608
Authentication-results: sourceware.org; auth=none
References: <CAEwic4Ycv_asbomwC2gpcjDLQmJ9LO023PBFtrmKA=9BXf58ag at mail dot gmail dot com> <53AAD6F1 dot 2080707 at redhat dot com> <CAEwic4bOmzQ_EbdSZKtNgxhdwes-7wn5PoyUcOBUv=hyZhrhkw at mail dot gmail dot com>

On 06/25/14 09:04, Kai Tietz wrote:

2014-06-25 16:04 GMT+02:00 Jeff Law <law@redhat.com>:

So why is the peephole not working in its current location?

Jeff


Hi Jeff,

that is what I read out of dumps:

If peephole2 is executed early we see following pattern transformation:

[ ... ]
Ask an ARM maintainer if the new code is actually better than the old code.

It appears that with the peep2 pass moved that we actually if-convertthe fall-thru path of the conditional and eliminate the conditional.Which, on the surface seems like a good thing. It may be the case thatwe need to twiddle the test. Not sure yet.



Jeff

Follow-Ups:
- Re: [patch passes.def]: Fix regression on ARM PR/61608
  - From: Ramana Radhakrishnan
- Re: [patch passes.def]: Fix regression on ARM PR/61608
  - From: Richard Henderson

References:
- [patch passes.def]: Fix regression on ARM PR/61608
  - From: Kai Tietz
- Re: [patch passes.def]: Fix regression on ARM PR/61608
  - From: Jeff Law
- Re: [patch passes.def]: Fix regression on ARM PR/61608
  - From: Kai Tietz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]