This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Move DECL_VINDEX and DECL_SAVED_TREE into function_decl

From: Jason Merrill <jason at redhat dot com>
To: Jan Hubicka <hubicka at ucw dot cz>
Cc: gcc-patches at gcc dot gnu dot org, rguenther at suse dot de
Date: Tue, 24 Jun 2014 16:49:57 -0400
Subject: Re: Move DECL_VINDEX and DECL_SAVED_TREE into function_decl
Authentication-results: sourceware.org; auth=none
References: <20140623202541 dot GA21820 at kam dot mff dot cuni dot cz> <53A990DC dot 8010409 at redhat dot com> <20140624181802 dot GA30367 at kam dot mff dot cuni dot cz>

On 06/24/2014 02:18 PM, Jan Hubicka wrote:

On 06/23/2014 04:25 PM, Jan Hubicka wrote:

	* class.c (check_methods, create_vtable_ptr, determine_key_method,
	add_vcall_offset_vtbl_entries_1): Guard VINDEX checks by FUNCTION_DECL check.


These changes are unnecessary: TYPE_METHODS is a list of functions.


I just double checked and there are template decls in the list, too. Those
always have VINDEX NULL, but with my change they naturally ICEs when you query
it.  I am re-testing the patch with the checks added back and intend to commit.


Ah, of course.  OK.

Jason

Follow-Ups:
- Re: Move DECL_VINDEX and DECL_SAVED_TREE into function_decl
  - From: Jan Hubicka

References:
- Move DECL_VINDEX and DECL_SAVED_TREE into function_decl
  - From: Jan Hubicka
- Re: Move DECL_VINDEX and DECL_SAVED_TREE into function_decl
  - From: Jason Merrill
- Re: Move DECL_VINDEX and DECL_SAVED_TREE into function_decl
  - From: Jan Hubicka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]