This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/3] add hash_map class
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Martin Liška <mliska at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 24 Jun 2014 20:23:49 +0200
- Subject: Re: [PATCH 3/3] add hash_map class
- Authentication-results: sourceware.org; auth=none
- References: <1403261538-884-1-git-send-email-tsaunders at mozilla dot com> <1403261538-884-3-git-send-email-tsaunders at mozilla dot com> <53A96F41 dot 4080301 at suse dot cz>
>
> On 06/20/2014 12:52 PM, tsaunders@mozilla.com wrote:
> >From: Trevor Saunders <tsaunders@mozilla.com>
> >
> >Hi,
> >
> >This patch adds a hash_map class so we can consolidate the boiler plate around
> >using hash_table as a map, it also allows us to get rid of pointer_map which I
> >do in this patch by converting its users to hash_map.
>
> Hello Trev,
> I like your changes! One small question about pointer_set, which is unable of deletion of items. Do you plan to migrate and simplify hash_map to be a replacement for pointer_set?
Note that pointer-map use in LTO is quite performance critical. It would be good to double
check that the new use of hash does not produce slower code.
Honza