This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] PR55189 enable -Wreturn-type by default
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Sylvestre Ledru <sylvestre at debian dot org>
- Cc: <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
- Date: Tue, 17 Jun 2014 17:41:23 +0000
- Subject: Re: [Patch] PR55189 enable -Wreturn-type by default
- Authentication-results: sourceware.org; auth=none
- References: <538F7856 dot 1090104 at debian dot org> <Pine dot LNX dot 4 dot 64 dot 1406042321130 dot 2874 at digraph dot polyomino dot org dot uk> <53903961 dot 9030501 at debian dot org> <Pine dot LNX dot 4 dot 64 dot 1406051749260 dot 2819 at digraph dot polyomino dot org dot uk> <53A07226 dot 4040803 at debian dot org> <Pine dot LNX dot 4 dot 64 dot 1406171712280 dot 23412 at digraph dot polyomino dot org dot uk> <53A07CCC dot 2030004 at debian dot org>
On Tue, 17 Jun 2014, Sylvestre Ledru wrote:
> OK. I will do that.
> We should test the following:
> * default => run just -Wreturn-type
> * -Wreturn-type => Run both
> * -Wreturn-type + -Wmissing-return => Run both
> * -Wno-return-type + -Wmissing-return => Run just the second one
> * -Wno-return-type + -Wno-missing-return => Run none
> Do you see any other?
That looks like the right things to test, if there are no changes for
anything other than those options.
> Besides that, are you OK with my changes? (with the tests updated)
The tests are key to reviewing whether the code changes actually do the
right thing.
--
Joseph S. Myers
joseph@codesourcery.com