This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: ipa-visibility TLC 2/n
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: David Edelsohn <dje dot gcc at gmail dot com>, Richard Biener <richard dot guenther at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Henderson <rth at redhat dot com>, ramrad01 at arm dot com, Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Thu, 12 Jun 2014 12:43:08 +0200
- Subject: Re: ipa-visibility TLC 2/n
- Authentication-results: sourceware.org; auth=none
- References: <20140529171214 dot GB32218 at kam dot mff dot cuni dot cz> <877g53ag1p dot fsf at talisman dot default> <CAGWvnyn1b_gDjoE9rfie0Q66Jmv7pYYMq+9NtNn5=cdJ8NPzrw at mail dot gmail dot com> <20140608165447 dot GC23686 at kam dot mff dot cuni dot cz> <20140608165838 dot GD23686 at kam dot mff dot cuni dot cz> <CAGWvny=RqnsPH7LGVmobJhOE8128UUz0Gtzp9_Nq5qmGsYXKxA at mail dot gmail dot com> <20140610180201 dot GE5439 at kam dot mff dot cuni dot cz> <CAGWvnyk76zqp8QY+yG0K_Ec4RVNtu+78Rfpt=wH+Q1iCi5TW5g at mail dot gmail dot com> <20140610225524 dot GC15233 at kam dot mff dot cuni dot cz> <yddfvjb34kk dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <20140611170250 dot GA21180 at kam dot mff dot cuni dot cz>
Hi Honza,
>> Unfortunately, AIX isn't the only target massively affected by your
>> recent patches. This all started with r210597
>>
>> 2014-05-17 Jan Hubicka <hubicka@ucw.cz>
>>
>> * tree-pass.h (make_pass_ipa_comdats): New pass.
>> * timevar.def (TV_IPA_COMDATS): New timevar.
>> * passes.def (pass_ipa_comdats): Add.
>> * Makefile.in (OBJS): Add ipa-comdats.o
>> * ipa-comdats.c: New file.
>>
>> At that time, only Solaris 11 with gas/Solaris ld was affected: many Go
>> tests started failing like this:
>>
>> runtime.SetFinalizer: cannot pass * os os.file to finalizer func(* os os.file) error
>> fatal error: runtime.SetFinalizer
>
> Thanks for letting me know. THis is different transformation than one
> causing trouble
> on AIX (AIX has no comdats, so this pass does nothing). Go seems tobe
> quite heavy user
> of comdat locals produced by that patch, so I suppose they somehow break
> with Solaris.
>
> Comdat locals are now used by ipa-comdats, for thunks and for decloned ctors.
> We probably need to figure out bit more precise limitation of Solaris and either
> fix or add way for target to say what kind of comdat locals are not supported.
Right. I'll start reghunting for the patch that caused additional
breakage even without comdat, as on Solaris 10.
> Can I reproduce your setup on the compile farm?
According to https://gcc.gnu.org/wiki/CompileFarm, there are no Solaris
machines or VMs in the compile farm. If a VM could be set up (no idea
if they allow non-free OSes beyond AIX there), I'd suggest starting with
Solaris 11.2 Beta
(http://www.oracle.com/technetwork/server-storage/solaris11/downloads/beta-2182939.html),
which has the latest in /bin/ld support. I can certainly help with
setting something up.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University