This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [fortran,patch] Fix Cray pointers in modules
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: FX <fxcoudert at gmail dot com>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 9 Jun 2014 09:56:34 +0200
- Subject: Re: [fortran,patch] Fix Cray pointers in modules
- Authentication-results: sourceware.org; auth=none
- References: <7AAE9C22-B5B1-460A-89FC-4C0FAF4782F9 at gmail dot com>
Dear Francois-Xavier,
The patch and the logic behind it, including the name dependence, is
fine. OK for trunk and, I suggest, 4.9 and 4.8 after a suitable
delay.
Thanks!
Paul
On 8 June 2014 18:40, FX <fxcoudert@gmail.com> wrote:
> The attached one-line patch fixes PR45187 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=45187), where we would sometimes try to create the backend_decl of Cray-pointees twice. We should simply bail out early of the procedure, following what is done in the similar situation in gfc_finish_var_decl().
>
> Bootstrapped and regtested on x86_64-apple-darwin13, includes a testcase.
> OK to commit?
>
> FX
>
--
The knack of flying is learning how to throw yourself at the ground and miss.
--Hitchhikers Guide to the Galaxy