This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ Patch] PR 43453

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Jason Merrill <jason at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Wed, 04 Jun 2014 22:10:23 +0200
Subject: Re: [C++ Patch] PR 43453
Authentication-results: sourceware.org; auth=none
References: <53834B3C dot 5060706 at oracle dot com> <538360A5 dot 4070707 at oracle dot com> <538F2A2E dot 3070708 at redhat dot com> <538F60B6 dot 9020706 at oracle dot com> <538F745E dot 1070201 at redhat dot com>

Hi,

On 06/04/2014 09:32 PM, Jason Merrill wrote:

On 06/04/2014 02:08 PM, Paolo Carlini wrote:
        /* An array of character type can be initialized from a
-     brace-enclosed string constant.
-
-     FIXME: this code is duplicated from reshape_init. Probably
-     we should just call reshape_init here?  */
It strikes me as odd that we get here before we strip the parens. Whatif we moved the paren code up out of store_init_value tocheck_initializer before the call to maybe_deduce_size_from_array_init?

Ok... At first I was worried by the othermaybe_deduce_size_from_array_init call, but I don't think theinitializer of a char array can be dependent, right? Then I'm finishingtesting the below.


Thanks!
Paolo.

///////////////////

Attachment: patch_43453_3
Description: Text document

Follow-Ups:
- Re: [C++ Patch] PR 43453
  - From: Paolo Carlini

References:
- Re: [C++ Patch] PR 43453
  - From: Jason Merrill
- Re: [C++ Patch] PR 43453
  - From: Paolo Carlini
- Re: [C++ Patch] PR 43453
  - From: Jason Merrill

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]