This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] rebuild frequency after vrp
- From: Dehao Chen <dehao at google dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <richard dot guenther at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>
- Date: Mon, 2 Jun 2014 10:26:25 -0700
- Subject: Re: [PATCH] rebuild frequency after vrp
- Authentication-results: sourceware.org; auth=none
- References: <CAO2gOZWFOuG2O0RLkkT5+tZOpDg+-=pBQk--88X+A-qObgDayw at mail dot gmail dot com> <20140602161326 dot GC16816 at kam dot mff dot cuni dot cz> <CAO2gOZV8WH5_u4_pxCApahgB2F9f=g=6PYb9u0Ppcw1GMLU82Q at mail dot gmail dot com> <538CAA25 dot 1010309 at redhat dot com>
Just tried with Teresa's patch, the ICE in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61384 is not resolved.
Dehao
On Mon, Jun 2, 2014 at 9:45 AM, Jeff Law <law@redhat.com> wrote:
> On 06/02/14 10:17, Dehao Chen wrote:
>>
>> We need to rebuild frequency after vrp, otherwise the following code
>> in tree-ssa-threadupdate.c will make the frequency larger than
>> upper-bound.
>>
>> /* Excessive jump threading may make frequencies large enough
>> so
>> the computation overflows. */
>> if (rd->dup_blocks[0]->frequency < BB_FREQ_MAX * 2)
>> rd->dup_blocks[0]->frequency += EDGE_FREQUENCY (e);
>>
>> This is referring to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61384
>
> Can you try this with Teresa's revamping of the jump threading frequency
> updates? It's still in my queue of things to review.
>
> Fixing this stuff in the updater would be better than rebuilding the
> frequencies, IMHO.
>
> Jeff
>