This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C/C++ PATCH] Add -Wlogical-not-parentheses (PR c/49706)

From: Jason Merrill <jason at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Cc: "Joseph S. Myers" <joseph at codesourcery dot com>
Date: Mon, 02 Jun 2014 10:08:24 -0400
Subject: Re: [C/C++ PATCH] Add -Wlogical-not-parentheses (PR c/49706)
Authentication-results: sourceware.org; auth=none
References: <20140602065052 dot GE31671 at redhat dot com>

On 06/02/2014 02:50 AM, Marek Polacek wrote:

+      && TREE_CODE (arg1.value) == EQ_EXPR)

...

+	  && TREE_CODE (current.lhs) == EQ_EXPR

It seems like your version only warns about ==, while the clang versionwarns about all comparisons.

+	  && (complain_flags (decltype_p) & tf_warning)

Let's not call complain_flags multiple times in the function. In factthis will always be true, so you could just drop it.

Also for C++, I think we don't want this warning to trigger when the
operator (==, !=, >, <, <=, >=) is overloaded.  But I admit
I haven't even tried that, and I don't know how to detect overloaded
operators except DECL_OVERLOADED_OPERATOR_P.

Overloaded operators have the same precedence, so I think it'sappropriate to give the warning whether or not the operators are overloaded.


Jason

Follow-Ups:
- Re: [C/C++ PATCH] Add -Wlogical-not-parentheses (PR c/49706)
  - From: Marek Polacek

References:
- [C/C++ PATCH] Add -Wlogical-not-parentheses (PR c/49706)
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]