This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch i386]: Expand sibling-tail-calls via accumulator register
- From: Richard Henderson <rth at redhat dot com>
- To: Kai Tietz <ktietz at redhat dot com>, Jeff Law <law at redhat dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>
- Date: Wed, 28 May 2014 10:22:35 -0700
- Subject: Re: [patch i386]: Expand sibling-tail-calls via accumulator register
- Authentication-results: sourceware.org; auth=none
- References: <356718653 dot 5712706 dot 1400794422397 dot JavaMail dot zimbra at redhat dot com> <CAMe9rOrCiRSTA+4jiGeQLub4P--KX8XzkYiwAVWZUxzunhvkPQ at mail dot gmail dot com> <537F8DC7 dot 3090906 at redhat dot com> <777706000 dot 8424762 dot 1401128436051 dot JavaMail dot zimbra at redhat dot com> <20140526183208 dot GG10386 at tucnak dot redhat dot com> <1487116948 dot 8449887 dot 1401132170121 dot JavaMail dot zimbra at redhat dot com> <20140526193543 dot GH10386 at tucnak dot redhat dot com> <625132578 dot 8474723 dot 1401136339171 dot JavaMail dot zimbra at redhat dot com> <643791243 dot 10265346 dot 1401266636155 dot JavaMail dot zimbra at redhat dot com>
On 05/28/2014 01:43 AM, Kai Tietz wrote:
> + if (GET_CODE (op) == CONST)
> + op = XEXP (op, 0);
> + return (GET_CODE (op) == SYMBOL_REF || CONSTANT_P (op));
Surely all this boils down to just CONSTANT_P (op),
without having to look through the CONST at all.
Otherwise this looks ok.
r~