This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix ICE in rtl-optimization/PR61220, PR61225

From: Jeff Law <law at redhat dot com>
To: Zhenqiang Chen <zhenqiang dot chen at linaro dot org>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Fri, 23 May 2014 12:20:22 -0600
Subject: Re: [PATCH] Fix ICE in rtl-optimization/PR61220, PR61225
Authentication-results: sourceware.org; auth=none
References: <CACgzC7Cqb-ZuL4WDJJRZ9SaN27Gy0p8gfH=-4ZbKe9AEh+LrGQ at mail dot gmail dot com> <537B88C9 dot 6040208 at redhat dot com> <CACgzC7B=vBQX_tR0fJzVbxCg-cAcPX3CLQeO5kTGRud645C7RA at mail dot gmail dot com>

On 05/20/14 20:12, Zhenqiang Chen wrote:

In the code, there are 4 combinations of EDGE_COUNT: <1, 1>, <1, 2>,
<2, 1> and <2, 2>.  <2, 1> is "illegal". <2, 2> is legal, but need
split_edge. <1, *> can bypass the second check. EDGE_CRITICAL_P can
only distinguish <2, 2> from others.

So I think two explicit checks is more efficient than EDGE_CRITICAL_P.

OK. It was more a question of clarity than efficiency. Your patch isfine as-is.


jeff

References:
- [PATCH] Fix ICE in rtl-optimization/PR61220, PR61225
  - From: Zhenqiang Chen
- Re: [PATCH] Fix ICE in rtl-optimization/PR61220, PR61225
  - From: Jeff Law
- Re: [PATCH] Fix ICE in rtl-optimization/PR61220, PR61225
  - From: Zhenqiang Chen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]