This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [MIPS] Add sbasic supoert ffor MSA (SIMD)
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Graham Stott <Graham dot Stott at imgtec dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 21 May 2014 17:59:16 +0000
- Subject: Re: [MIPS] Add sbasic supoert ffor MSA (SIMD)
- Authentication-results: sourceware.org; auth=none
- References: <83760FF4D445E74A822AAB0E7BFE5F754051CCC4 at KLMAIL01 dot kl dot imgtec dot org>
On Wed, 21 May 2014, Graham Stott wrote:
> msa.h is included, which will be installed when configured/built/installed.
> It provides prototypes, typedefs etc for the vector types used MSA its contents follow the MSA whitepaper.
Unless it's part of the defined interface that the user may not have
macros called "vector_size", "aligned", "a", "b" and "c", you should use
the __*__ attribute names, and __a etc. parameter names, to be
namespace-clean.
You shouldn't need to declare __builtin_* functions anyway. And if a
function can be represented directly with GNU C vector extensions, it's
preferred to implement it that way inline in the header rather than having
built-in functions duplicating existing GNU C functionality. (Look at
what AArch64 arm_neon.h does where possible, and what ARM arm_neon.h has
been moved towards lately. I don't now what the msa.h functions do, so I
don't know if this actually applies to any of them - but it's something to
consider, so that built-in functions are only defined where actually
needed.)
Use appropriate @dots{} and @minus{} markup in the documentation.
--
Joseph S. Myers
joseph@codesourcery.com