Re: [patch ping] libstdc++ testsuite cxxflags

[Sandra Loosemore <sandra at codesourcery dot com>]

On 05/17/2014 04:07 AM, Jonathan Wakely wrote:
> On 17 May 2014 10:50, Jonathan Wakely wrote:
> > On 17 May 2014 01:16, Sandra Loosemore wrote:
> > > It appears that this patch from last fall never got reviewed.
> > >
> > > https://gcc.gnu.org/ml/gcc-patches/2013-10/msg02340.html
> > >
> > > Can someone take a look?  I'll commit the patch on Cesar's behalf if it's
> > > approved.
> >
> > Libstdc++ patches need to go to the libstdc++ list, which this did, in
> > a separate mail that broke the threading:
> > https://gcc.gnu.org/ml/libstdc++/2013-10/msg00224.html
> > Then archives's inability to thread betweem months broke it again:
> > https://gcc.gnu.org/ml/libstdc++/2013-11/msg00113.html
> >
> > I approved it then withdrew that approval:
> > https://gcc.gnu.org/ml/libstdc++/2013-11/msg00120.html
> > then the patch got revised:
> > https://gcc.gnu.org/ml/libstdc++/2013-11/msg00122.html
> >
> > I'll have to refresh my memory about it.

Whoops, I totally missed that there was already a separate thread on the 
libstdc++ mailing list only.  My bad.  :-(

> I think I'm happiest with the second version of the patch, in
> https://gcc.gnu.org/ml/libstdc++/2013-11/msg00114.html
>
> It does mean a change that might affect people using CXXFLAGS when
> running the tests, so we might want to update
> https://gcc.gnu.org/onlinedocs/libstdc++/manual/test.html where it says
> "Or, just run the testsuites with CXXFLAGS set to -D_GLIBCXX_DEBUG or
> -D_GLIBCXX_PARALLEL."

I came up with the attached patch for the wording change.  I'm having 
trouble regenerating the HTML version of the manual, though; it looks 
like I have a different version of the DocBook stylesheets around that 
are introducing lots of extraneous changes, and I'm not sure what the 
"right" version is.  :-S  Any suggestions?

-Sandra

Index: libstdc++-v3/doc/xml/manual/test.xml
===================================================================
--- libstdc++-v3/doc/xml/manual/test.xml	(revision 210575)
+++ libstdc++-v3/doc/xml/manual/test.xml	(working copy)
@@ -478,9 +478,11 @@ runtest --tool libstdc++ --srcdir=/path/
     </para>
 
     <para>
-      Or, just run the testsuites with <constant>CXXFLAGS</constant>
-      set to <constant>-D_GLIBCXX_DEBUG</constant> or
-      <constant>-D_GLIBCXX_PARALLEL</constant>.
+      You can also run the testsuites by setting
+      <constant>CXXFLAGS</constant> in the environment.  In this case,
+      however, you should also make sure that <constant>CXXFLAGS</constant>
+      includes <constant>-g -O2</constant>, since some tests assume the
+      presence of these options.
     </para>
   </section>
 </section>