This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patch8.diff updated Was: Re: GCC's -fsplit-stack disturbing Mach's vm_allocate
- From: Svante Signell <svante dot signell at gmail dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: Samuel Thibault <samuel dot thibault at gnu dot org>, Thomas Schwinge <thomas at codesourcery dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, bug-hurd <bug-hurd at gnu dot org>, Roland McGrath <roland at hack dot frob dot com>
- Date: Fri, 16 May 2014 15:40:45 +0200
- Subject: Re: patch8.diff updated Was: Re: GCC's -fsplit-stack disturbing Mach's vm_allocate
- Authentication-results: sourceware.org; auth=none
- References: <1399018692 dot 8487 dot 7 dot camel at PackardBell-PC> <20140502095753 dot GC6577 at type> <20140502100027 dot GD6577 at type> <1399027556 dot 8487 dot 12 dot camel at PackardBell-PC> <20140502105234 dot GM6577 at type> <1399363609 dot 13092 dot 29 dot camel at G3620 dot my dot own dot domain> <20140506125157 dot GH5788 at type dot bordeaux dot inria dot fr> <1399381520 dot 13092 dot 67 dot camel at G3620 dot my dot own dot domain> <20140506130755 dot GL5788 at type dot bordeaux dot inria dot fr> <1399382738 dot 13092 dot 70 dot camel at G3620 dot my dot own dot domain> <20140506132605 dot GD1010 at type dot bordeaux dot inria dot fr> <1399450727 dot 13092 dot 106 dot camel at G3620 dot my dot own dot domain> <1400227385 dot 10012 dot 98 dot camel at G3620 dot my dot own dot domain> <CAKOQZ8xpVSa2V-7uAqmwtVzQj6BxrO-pzQ5FF1XThxBVjc3yEg at mail dot gmail dot com>
- Reply-to: svante dot signell at gmail dot com
On Fri, 2014-05-16 at 06:20 -0700, Ian Lance Taylor wrote:
> On Fri, May 16, 2014 at 1:03 AM, Svante Signell
> <svante.signell@gmail.com> wrote:
> >
> > For that part of the patch without it the build on GNU/Hurd fails. On
> > the other hand SYS_FCNTL is not defined for e.g. GNU/Linux either. This
> > is used in gcc-4.9-4.9.0/src/libgo/go/net/fd_unix.go:
> > func dupCloseOnExec(fd int) (newfd int, err error) {
> > if atomic.LoadInt32(&tryDupCloexec) == 1 && syscall.F_DUPFD_CLOEXEC!=0 {
> > r0, _, e1 := syscall.Syscall(syscall.SYS_FCNTL, uintptr(fd),
> > syscall.F_DUPFD_CLOEXEC, 0)
> >
> > It is yet unknown how the build succeeds on Linux without the SYS_FCNTL
> > being defined? Maybe any the conditions above are not met.
>
> On GNU/Linux SYS_FCNTL is defined by the generated file sysinfo.go,
> because SYS_fcntl is defined by <syscall.h>.
Thanks, then that part of the patch should read:
# Special treatment of _SYS_fcntl for GNU/Hurd
if ! grep '^const _SYS_fcntl' ${OUT} > /dev/null 2>&1; then
echo "const SYS_FCNTL = 0" >> ${OUT}
fi
Shall I submit a new patch8.diff (or all patches again)?