This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: add dbgcnt and opt-info support for devirtualization
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Xinliang David Li <davidxl at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Fri, 16 May 2014 13:00:36 +0200
- Subject: Re: add dbgcnt and opt-info support for devirtualization
- Authentication-results: sourceware.org; auth=none
- References: <CAAkRFZKGLC9vW3-niUu2QrQGKZzUeq6Qv989bOaHdLjkn=6JqA at mail dot gmail dot com>
On Fri, May 16, 2014 at 1:54 AM, Xinliang David Li <davidxl@google.com> wrote:
> Hi, debugging runtime bugs due to devirtualization can be hard for
> very large C++ programs with complicated class hierarchy. This patch
> adds the support to report this high level transformation via
> -fopt-info (not hidden inside dump file) and the ability the do binary
> search with cutoff.
>
> Ok for trunk after build and test?
+ else if (dump_enabled_p ())
+ {
+ location_t loc = gimple_location (ie->call_stmt);
+ dump_printf_loc (MSG_OPTIMIZED_LOCATIONS, loc,
+ "Discovered direct call to non-function in %s, "
diagnostics start with lower-case. Why not merge this with the
dump_file case? The point of all the infrastructure was to _not_
need to distinguish the cases ...
(similar for the other cases, and IIRC you miss one case in
tree-ssa-pre.c calling ipa_intraprocedural_devirtualization?)
Thanks,
Richard.
> thanks,
>
> David