This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly
- From: Jeff Law <law at redhat dot com>
- To: John Marino <gnugcc at marino dot st>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Jonathan Wakely <jwakely dot gcc at gmail dot com>, Gerald Pfeifer <gerald at pfeifer dot com>, manu at gcc dot gnu dot org, "Eric Botcazou (gnu.org)" <ebotcazou at gcc dot gnu dot org>
- Date: Thu, 08 May 2014 23:26:55 -0600
- Subject: Re: Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly
- Authentication-results: sourceware.org; auth=none
- References: <5352D100 dot 9040108 at marino dot st> <Pine dot LNX dot 4 dot 64 dot 1405012259450 dot 16441 at digraph dot polyomino dot org dot uk> <5362DC9B dot 8090709 at marino dot st> <Pine dot LNX dot 4 dot 64 dot 1405021746390 dot 4946 at digraph dot polyomino dot org dot uk> <5363E0F4 dot 4060900 at marino dot st> <Pine dot LNX dot 4 dot 64 dot 1405022013520 dot 7129 at digraph dot polyomino dot org dot uk> <53649694 dot 6050508 at marino dot st>
On 05/03/14 01:11, John Marino wrote:
revised patchset :
http://leaf.dragonflybsd.org/~marino/gcc-df-target/patches/patch-dragonfly-target
revised changelog :
http://leaf.dragonflybsd.org/~marino/gcc-df-target/changelog_entries/gcc_ChangeLog_entry.txt
revised commit msg:
http://leaf.dragonflybsd.org/~marino/gcc-df-target/proposed_commit-msg.txt
Good catch! Does the rest of the patch set look good to you? I think
all the non-obvious patches have been reviewed collectively by various
people now and may be ready to be approved now.
In config.gcc:
+ no | gnat | single)
+ # Let these non-posix thread selections fall through if requested
Support for "gnat" as a thread model was removed in 2011. So I think
you need to remove that case.
configure.ac:
+ *-*-dragonfly* | *-*-freebsd*)
+ if grep dl_iterate_phdr $target_header_dir/sys/link_elf.h >
/dev/null 2>&1; then
+ gcc_cv_target_dl_iterate_phdr=yes
+ else
+ gcc_cv_target_dl_iterate_phdr=no
+ fi
+ ;;
Presumably you intended to change freebsd* here. Just want a
confirmation. I haven't worked on the *bsd platforms in about 20 years,
so I have no idea if this is right for them in general.
I see you have a dragonfly-stdint.h. Is there a particular reason why
you can't use the freebsd-stdint.h? I didn't check every type, but a
quick glance makes me think they ought to be equivalent.
Similarly for dragonfly.opt.
It looks like there's a fair amount of duplication in config/dragonfly.h
and config/i386/dragonfly but I don't see an easy way to fix that. So,
I'll let that go.
I'm going to trust the unwind code works and isn't duplicating something
from somewhere else that ought to instead be shared.
So it basically looks good. Can you fix the config.gcc nit and
determine if we can (and should) share files with freebsd. Repost after
those fixes and we should be ready to go.
And one final thing, do you have a copyright assignment on file with the
FSF?
jeff