This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Hurd port for gcc go PATCH 7-9 (9)
- From: Svante Signell <svante dot signell at gmail dot com>
- To: Samuel Thibault <samuel dot thibault at gnu dot org>
- Cc: bug-hurd <bug-hurd at gnu dot org>, debian-hurd <debian-hurd at lists dot debian dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 06 May 2014 14:13:54 +0200
- Subject: Re: Hurd port for gcc go PATCH 7-9 (9)
- Authentication-results: sourceware.org; auth=none
- References: <1399366718 dot 13092 dot 53 dot camel at G3620 dot my dot own dot domain> <20140506090702 dot GK5788 at type dot bordeaux dot inria dot fr>
- Reply-to: svante dot signell at gmail dot com
On Tue, 2014-05-06 at 11:07 +0200, Samuel Thibault wrote:
> Svante Signell, le Tue 06 May 2014 10:58:38 +0200, a Ãcrit :
> > The patch for st_dev by Thomas Schwinge was not liked by Samuel
>
> Uh?
>
> I said âThese should be fine, however.â and âa sed rule can't hurt even
> if there is no occurrence...â
>
> So just keep that precise part back as it was, no need for being clumsy.
>
> What I however said was:
>
> âErr, these seem to get applied to all systems, not just GNU/Hurd, isn't
> that a concern?â
>
> By that, I mean this:
>
> > +# Special treatment of EWOULDBLOCK for GNU/Hurd
> > +# /usr/include/bits/errno.h: #define EWOULDBLOCK EAGAIN
> > +egrep '^const EWOULDBLOCK = Errno(_EWOULDBLOCK)' ${OUT} | \
> > + sed -i.bak -e 's/_EWOULDBLOCK/_EAGAIN/' ${OUT}
> > +
This applies to all systems yes, how to modify?
> and that:
>
> > +# Special treatment of SYS_FCNTL for GNU/Hurd
> > +if ! grep '^const SYS_FCNTL' ${OUT} >/dev/null 2>&1; then
> > + echo "const SYS_FCNTL = 0" >> ${OUT}
> > +fi
And this applies to systems not defining FCNTL.
How many systems could possibly be affected?
> AIUI, the patch you propose does those changes for all systems, not just
> GNU/Hurd. That most probably will pose a problem.
And you wrote in your reply to the above: see e.g.
http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00644.html
> These should be fine, however.
I asked for help with sed but have not obtained any yet, so what to do?