Re: [SH, committed] add missing function* argument in sh_optimize_sett_clrt::execute

[Trevor Saunders <tsaunders at mozilla dot com>]

On Sat, May 03, 2014 at 10:24:31PM +0200, Oleg Endo wrote:
> Hi,
> 
> I've committed the attached patch as r210040, which reinstates the RTL
> pass.
> 
> Trevor, could you please double check that you haven't missed any other
> cases in your pass refactoring patches?

I have no clue how this happened, I remember changing it... :(

Anyway I did another round of greping and just finished looking over a
set of config-list.mk results, and didn't find anything.

thanks and sorry~

Trev

> 
> Cheers,
> Oleg
> 
> gcc/ChangeLog:
> 	* config/sh/sh_optimize_sett_clrt.cc (sh_optimize_sett_clrt::execute):
> 	Add missing function* argument.

> Index: gcc/config/sh/sh_optimize_sett_clrt.cc
> ===================================================================
> --- gcc/config/sh/sh_optimize_sett_clrt.cc	(revision 210027)
> +++ gcc/config/sh/sh_optimize_sett_clrt.cc	(working copy)
> @@ -79,8 +79,8 @@
>  public:
>    sh_optimize_sett_clrt (gcc::context* ctx, const char* name);
>    virtual ~sh_optimize_sett_clrt (void);
> -  virtual bool gate (function *);
> -  virtual unsigned int execute (void);
> +  virtual bool gate (function*);
> +  virtual unsigned int execute (function* fun);
>  
>  private:
>    static const pass_data default_pass_data;
> @@ -161,13 +161,13 @@
>  }
>  
>  bool
> -sh_optimize_sett_clrt::gate (function *)
> +sh_optimize_sett_clrt::gate (function*)
>  {
>    return optimize > 0;
>  }
>  
>  unsigned int
> -sh_optimize_sett_clrt::execute (void)
> +sh_optimize_sett_clrt::execute (function* fun)
>  {
>    unsigned int ccr0 = INVALID_REGNUM;
>    unsigned int ccr1 = INVALID_REGNUM;
> @@ -205,7 +205,7 @@
>    // Look for insns that set the ccreg to a constant value and see if it can
>    // be optimized.
>    basic_block bb;
> -  FOR_EACH_BB_REVERSE_FN (bb, cfun)
> +  FOR_EACH_BB_REVERSE_FN (bb, fun)
>      for (rtx next_i, i = NEXT_INSN (BB_HEAD (bb));
>  	 i != NULL_RTX && i != BB_END (bb); i = next_i)
>        {

Attachment: signature.asc
Description: Digital signature