This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, ARM] Fix PR60609 (Error: value of 256 too large for field of 1 bytes)
- From: Charles Baylis <charles dot baylis at linaro dot org>
- To: ramrad01 at arm dot com, Yvan Roux <yvan dot roux at linaro dot org>
- Cc: Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Joey Ye <joey dot ye at arm dot com>
- Date: Fri, 25 Apr 2014 16:29:57 +0100
- Subject: Re: [PATCH, ARM] Fix PR60609 (Error: value of 256 too large for field of 1 bytes)
- Authentication-results: sourceware.org; auth=none
- References: <CADnVucBLd0YBEWsJGFVNTktuGh-72cxXmNH0HnK-+6TytO-s6Q at mail dot gmail dot com> <CAJA7tRYCROs+SqrAMZ4weBz+ZxqVQMAY-4zOuSr99ANhFLB8DA at mail dot gmail dot com> <533EB72C dot 40109 at redhat dot com> <CAJA7tRYCwcKADkpT_48vjGnPt+1to67FyGj75JOSsJam5BVAMg at mail dot gmail dot com> <CADnVucA_Bpyw29p7MCfOkf19PzKOgLfqqH2ruFsvdp8OCQcfwQ at mail dot gmail dot com>
This doesn't seem to have shown problems on trunk/4.9.
I have bootstrapped and checked the patch on 4.8
arm-unknown-linux-gnueabihf (Thumb-2) on qemu.
I have checked the patch on 4.7 arm-unknown-linux-gnueabihf (Thumb-2) on qemu.
OK to backport to 4.8 and 4.7?
On 7 April 2014 16:02, Charles Baylis <charles.baylis@linaro.org> wrote:
> On 4 April 2014 15:50, Ramana Radhakrishnan <ramana.gcc@googlemail.com> wrote:
>> Additionally the testing has only considered Thumb2 - since we also do
>> jumptable shortening for Thumb1 and given this late change it's worth
>> also testing this on Thumb1 and making sure there are no regressions.
>> Maybe Joey can help there if you aren't set up to do this.
>>
>> Ok if no regressions and modulo RM objections.
>
> I have tested v5t Thumb-1 with no regressions on qemu.
>
>> One minor Changelog nit.
>>
>> 2014-04-02 Charles Baylis <charles.baylis@linaro.org>
>>
>> PR target/60609
>> * config/arm/arm.h (ASM_OUTPUT_CASE_END) Remove.
>> (LABEL_ALIGN_AFTER_BARRIER) Align barriers which occur after
>> ADDR_DIFF_VEC.
>>
>> s/)/):/g above.
>
> Noted.