This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 00/89] Compile-time gimple-checking
- From: Michael Matz <matz at suse dot de>
- To: Andrew MacLeod <amacleod at redhat dot com>
- Cc: David Malcolm <dmalcolm at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 24 Apr 2014 16:49:12 +0200 (CEST)
- Subject: Re: [PATCH 00/89] Compile-time gimple-checking
- Authentication-results: sourceware.org; auth=none
- References: <1398099480-49147-1-git-send-email-dmalcolm at redhat dot com> <alpine dot LNX dot 2 dot 00 dot 1404231636530 dot 20425 at wotan dot suse dot de> <53590DBB dot 80104 at redhat dot com>
Hi,
On Thu, 24 Apr 2014, Andrew MacLeod wrote:
> Well, we ought to settle on one... either use the is_a, as_a, and
> dyn_cast paradigm as they exist today, or we use the cast_as_method
> approach everywhere. I'm not fond of each potential project having a
> different approach... I'd like to see a consistent look throughout.
>
> I suspect the cast_as_method has compile time advantages, as well as
> error reporting ones.... (have you seen the kind of message you get when
> the template instantiation doesn't work right? ick!) , but it suffers
> from having to modify the base class whenever a new derived class is
> added...
Well, when adding new derived classes is such a frequent event that this
would be of any worry, then we have much more difficult problems. Adding
types should be a well thought out and hence rare event.
> (which seems a little "dirty" and could impact possible future
> enhancements).
Perhaps dirty from some artificial language cleanliness perspective
(although why would methods be regarded as dirty?). I call it pragmatic
and visually undisturbing.
Ciao,
Michael.