This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Fix obsolete autoconf macros in configure.ac
- From: Steve Ellcey <sellcey at mips dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 23 Apr 2014 10:32:26 -0700
- Subject: Re: [Patch] Fix obsolete autoconf macros in configure.ac
- Authentication-results: sourceware.org; auth=none
- References: <c2056f21-f4f5-4719-a540-881cd78d219b at BAMAIL02 dot ba dot imgtec dot org> <87bnvsroci dot fsf at igel dot home>
On Wed, 2014-04-23 at 18:40 +0200, Andreas Schwab wrote:
> "Steve Ellcey " <sellcey@mips.com> writes:
>
> > diff --git a/gcc/configure.ac b/gcc/configure.ac
> > index d789557..98acb1b 100644
> > --- a/gcc/configure.ac
> > +++ b/gcc/configure.ac
> > @@ -1083,8 +1083,8 @@ int main()
> > fi
> > fi
> >
> > -AC_CHECK_TYPE(ssize_t, int)
> > -AC_CHECK_TYPE(caddr_t, char *)
> > +AC_CHECK_TYPES([ssize_t])
> > +AC_CHECK_TYPES([caddr_t])
>
> You also need to handle the no longer supported default definition.
> Moreover, the two macro calls can be combined into one.
>
> Andreas.
Actually, now that I look more at caddr_t, I see that we probably
shouldn't be using it at all. The only uses in the gcc subdirectory are
for calls to mmap and munmap (in gcc.c, gcc-common.c, and
config/host-solaris.c) and the latest definitions for mmap and munmap
say it should use 'void *', not caddr_t. I will submit a new
patch to remove the uses (and definition) of caddr_t from gcc.
ssize_t should probably still be fixed, but that was not causing me a
failure and it can be handled separately.
Steve Ellcey
sellcey@mips.com