This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Remove "keep_aligning" from get_inner_reference
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- Cc: gcc-patches at gcc dot gnu dot org, Richard Biener <richard dot guenther at gmail dot com>, Martin Jambor <mjambor at suse dot cz>, Jakub Jelinek <jakub at redhat dot com>
- Date: Tue, 22 Apr 2014 10:09:28 +0200
- Subject: Re: [PATCH] Remove "keep_aligning" from get_inner_reference
- Authentication-results: sourceware.org; auth=none
- References: <20130910193228 dot GE6732 at virgil dot suse> <CAFiYyc1v1oVWF-WzKdiGbWh6tq-dXXhWacSXYXzeypSUTo9kvQ at mail dot gmail dot com> <DUB129-W705A7F98D8316229E61A30E4590 at phx dot gbl>
> I still have that already-approved patch, updated to current trunk.
> I've successfully boot-strapped it on armv7-linux-gnueabihf with
> all languages enabled, including Ada.
> The test suite runs cleanly without any drop-outs.
Thanks for the testing.
> Is it OK to commit now, or are there objections?
I think that the patch is either incomplete or wrong, in the sense that it
will break TYPE_ALIGN_OK support, unless this support is totally obsolete, in
which case it ought to be totally removed instead of just partially. The Ada
testsuite in the compiler isn't exhaustive enough to give any guarantee so I
will need to conduct more testing. Can you sit on the patch a few weeks?
--
Eric Botcazou