This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Testsuite PATCH to add support for dlopen tests
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Hans-Peter Nilsson <hp at bitrange dot com>, ramrad01 at arm dot com, Steve Ellcey <sellcey at mips dot com>, Dominique Dhumieres <dominiq at lps dot ens dot fr>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <richard dot guenther at gmail dot com>, jason at redhat dot com
- Date: Mon, 14 Apr 2014 08:40:10 +0200
- Subject: Re: RFA: Testsuite PATCH to add support for dlopen tests
- Authentication-results: sourceware.org; auth=none
- References: <20140408081007 dot F25D5103 at mailhost dot lps dot ens dot fr> <1396978104 dot 6866 dot 27 dot camel at ubuntu-sellcey> <CAJA7tRaDbqvSzx31H+rWVXiaFKbBg5O3uZ3jeFPvZ=G6Lswbmw at mail dot gmail dot com> <20140411071828 dot GP1817 at tucnak dot redhat dot com> <alpine dot BSF dot 2 dot 02 dot 1404132113350 dot 60850 at arjuna dot pair dot com> <20140414062929 dot GJ1817 at tucnak dot redhat dot com>
Jakub Jelinek <jakub@redhat.com> writes:
>> I just noticed that I see this error, so the problem still
>> exists at r209347 (seen for cris-elf).
>>
>> (The FAILs are old and provided only for context; the ERRORs are
>> fatal.)
>
> Does say following patch make the problem go away?
>
> --- gcc/gcc/testsuite/g++.dg/dso/dlclose1.C 2014-04-11 10:33:22.552213377 +0200
> +++ gcc/gcc/testsuite/g++.dg/dso/dlclose1.C 2014-04-14 08:27:57.311138264 +0200
> @@ -1,7 +1,7 @@
> // PR c++/60731
> // { dg-do run { target { dlopen && disable-for-4.9 } } }
> // { dg-add-options dlopen }
> -// { dg-build-dso "dlclose1-dso.cc" }
> +// ( dg-build-dso "dlclose1-dso.cc" )
It would: I've used this instead:
> -// { dg-build-dso "dlclose1-dso.cc" }
> +// { dg- build-dso "dlclose1-dso.cc" }
dg-build-dso is evaluated even if the test isn't run. And the problem
is indeed the missing support for nested dg-test invocations. I should
have known since I provided the patch for that 3 years ago ;-)
My suggestion is to leave Jason's reversal for the 4.9 branch. For
mainline, we should require DejaGnu >= 1.5, but before reverting the
reversal, I'll try to come up with a check that avoids skipping large
parts of g++.dg with an older version.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University