This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch: RL78] Add support for 64-bit doubles
- From: DJ Delorie <dj at redhat dot com>
- To: Kaushik Phatak <Kaushik dot Phatak at kpit dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 26 Mar 2014 16:38:37 -0400
- Subject: Re: [Patch: RL78] Add support for 64-bit doubles
- Authentication-results: sourceware.org; auth=none
- References: <f7d129396d8f4f90a6e184b48472c3b9 at HKNPR03MB001 dot apcprd03 dot prod dot outlook dot com> <27a0647fa3b24ab4877d0709d1936598 at HKNPR03MB001 dot apcprd03 dot prod dot outlook dot com> ,<1f40a6f4f2b64320a3598ff9fc63d10d at HKNPR03MB001 dot apcprd03 dot prod dot outlook dot com> <29b3d0d347b34468be6f471c9384a35e at HKNPR03MB001 dot apcprd03 dot prod dot outlook dot com> <79a8e187348345229618ee9d09d52fed at HKNPR03MB001 dot apcprd03 dot prod dot outlook dot com>
Sorry about the delay on this. As GCC is in pre-release and it would
be bad for 4.9 to pass options that a released binutils doesn't
support, I hesitate to approve this at this time. It looks OK, it's
just the timing is bad. Please remind us after GCC is back in stage1.
I would also like to see an explicit initialization for the variable
to guarantee that the default is 32-bit-doubles, or some other
notation that guarantees the default.
Also, please note in the reminder that you've tested both options and
don't see any differences in the testsuite results between them that
reflect bugs in DFmode double support. Just because you've enabled
the type doesn't mean it will work properly.