This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, fortran] PR34928 - Extension: volatile common blocks

From: Tobias Burnus <burnus at net-b dot de>
To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>, Dominique Dhumieres <dominiq at lps dot ens dot fr>
Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
Date: Wed, 26 Mar 2014 20:34:28 +0100
Subject: Re: [Patch, fortran] PR34928 - Extension: volatile common blocks
Authentication-results: sourceware.org; auth=none
References: <20140326175615 dot 175AC108 at mailhost dot lps dot ens dot fr> <20140326192602 dot GA14388 at troutmask dot apl dot washington dot edu>

Steve Kargl wrote:

On Wed, Mar 26, 2014 at 06:56:15PM +0100, Dominique Dhumieres wrote:

Updated patch. OK to commit?

OK.


I have a minor nit: can you add a @code{} around the second VOLATILE?

+Some Fortran compilers, including @command{g77}, let the user declare
+@code{COMMON} with the @code{VOLATILE} attribute. This is
+invalid standard Fortran syntax and is not supported by
+@command{gfortran}.  Note that @command{gfortran} accepts VOLATILE
+variables in COMMON blocks since revision 4.3.

Thanks for the patch - and welcome to the club of GCC contributors withcommit access :-)


Tobias

Follow-Ups:
- Re: [Patch, fortran] PR34928 - Extension: volatile common blocks
  - From: Dominique Dhumieres

References:
- Re: [Patch, fortran] PR34928 - Extension: volatile common blocks
  - From: Dominique Dhumieres
- Re: [Patch, fortran] PR34928 - Extension: volatile common blocks
  - From: Steve Kargl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]